Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ScopeProvider in Pass #1385

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Implement ScopeProvider in Pass #1385

merged 2 commits into from
Nov 30, 2023

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Nov 30, 2023

This PR implements the ScopeProvider interface in the Pass class. This should now enable passes to use the information in the stored scopeManager when creating new nodes with the node builder.

@oxisto
Implement ScopeProvider in Pass
225c982 
This PR implements the `ScopeProvider` interface in the `Pass` class. This should now enable passes to use the information in the stored `scopeManager` when creating new nodes with the node builder.
@oxisto oxisto requested a review from konradweiss as a code owner November 30, 2023 11:38
maximiliankaul
maximiliankaul approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@oxisto oxisto enabled auto-merge (squash) November 30, 2023 14:33
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit c81ef60 into main Nov 30, 2023
4 checks passed
@oxisto oxisto deleted the use-scope-provider-in-pass branch November 30, 2023 14:39
oxisto added a commit that referenced this pull request Dec 30, 2023
@oxisto
Implement ScopeProvider in Pass (#1385)
a295e0a 
This PR implements the `ScopeProvider` interface in the `Pass` class. This should now enable passes to use the information in the stored `scopeManager` when creating new nodes with the node builder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankaul maximiliankaul maximiliankaul approved these changes

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxisto @maximiliankaul